Skip to content

Support uppercase custom type identifiers in Schema.sql #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Copilot wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Support uppercase custom type identifiers in Schema.sql #2189

Copilot wants to merge 5 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Dec 13, 2025 •
edited
Loading

Support capital type definition in .sql

  • Understand the issue: uppercase enum types not properly handled
  • Fix Parser.hs to handle quoted identifiers in custom types
  • Fix Compiler.hs to properly quote custom type names
  • Add test for parsing uppercase enum type definition
  • Add test for parsing table with uppercase custom type column
  • Add test for compiling uppercase custom type
  • Add integration test demonstrating full round-trip
  • Add migration generator tests for uppercase quoted enum types
  • Add Haskell code generation tests for uppercase custom types
  • Fix test assertion methods
  • Code review - passed with no issues
  • Security check - no security issues found

Summary

Fixed the issue where uppercase enum type definitions (e.g., CREATE TYPE "SYMBOL_TYPE") were not properly supported in the Schema Designer.

Root Cause:

  1. Parser used takeWhile1P instead of identifier parser for custom types, rejecting quoted identifiers
  2. Compiler didn't quote custom type names, causing uppercase types to be output without quotes

Solution:

  1. Changed customType parser to use identifier parser to accept quoted identifiers
  2. Changed compilePostgresType (PCustomType) to use compileIdentifier for proper quoting

Test Coverage:

  • Parser tests: 3 tests for parsing uppercase enum types and tables
  • Compiler tests: 3 tests for compiling uppercase custom types
  • Migration generator tests: 2 tests verifying migrations work correctly with uppercase quoted enum types
  • Haskell code generation tests: 2 tests verifying uppercase enum types generate correct Haskell code

Test Fix: Changed from shouldContain (not available for Text) to extracting the specific line and using shouldBe for proper comparison.

The fix is minimal (2 lines of code changed) and ensures uppercase custom types work correctly throughout the schema parsing, compilation, migration, and Haskell code generation pipeline.

Original prompt

This section details on the original issue you should resolve

<issue_title>Support capital type definition in .sql?</issue_title>
<issue_description>Now I have to use lowercase to define type as

-- Your database schema. Use the Schema Designer at http://localhost:8001/ to add some tables.
CREATE TYPE node_type AS ENUM ('folder', 'file');
CREATE TYPE cell_type AS ENUM ('raw', 'image', 'backtest');
CREATE TYPE symbol_type AS ENUM ('stock', 'etf', 'future', 'option', 'fund');
CREATE TABLE symbol (
    id UUID DEFAULT uuid_generate_v4() PRIMARY KEY NOT NULL,
    code TEXT NOT NULL,
    name TEXT NOT NULL,
    symbol_type symbol_type NOT NULL,
    list_date TIMESTAMP WITHOUT TIME ZONE NOT NULL,
    delist_date TIMESTAMP WITHOUT TIME ZONE,
    UNIQUE(code, symbol_type)
);

If I use CREATE TYPE "SYMBOL_TYPE" AS ENUM ('stock', 'etf', 'future', 'option', 'fund') to define enum type. I have to write symbol_type "SYMBOL_TYPE" NOT NULL in creating symbol table. And there will be an error as follow when I enter localhost:8001.
Image

If I write symbol_type SYMBOL_TYPE NOT NULL without "". ihp-migration will treat SYMBOL_TYPE as lowercase symbol_type. This will generate a new migration to lowercase definition.

Using lowercase to define type is OK in everywhere. But using capital to define type is more better to uniform type definition of database. Do you have any plan to support using capital to define database type?</issue_description>

<agent_instructions>pls take a look and see whether we can support this. make sure to add the example from the issue as a test. thx!</agent_instructions>

Comments on the Issue (you are @copilot in this section)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@mpscholten
Fix support for uppercase custom type definitions in SQL
3535567 
Co-authored-by: mpscholten <2072185+mpscholten@users.noreply.github.com>
Copilot AI changed the title [WIP] Support capital type definition in SQL Support uppercase custom type identifiers in Schema.sql Dec 13, 2025
Copilot AI requested a review from mpscholten December 13, 2025 14:26
@mpscholten
Copy link
Member

mpscholten commented Dec 13, 2025

@copilot we also need a test for the code gen

@mpscholten
Add migration generator tests for uppercase quoted enum types
a16d19f 
Co-authored-by: mpscholten <2072185+mpscholten@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 13, 2025

@copilot we also need a test for the code gen

Added migration generator tests in commit a16d19f. The tests verify that:

  1. Uppercase quoted enum types with tables using them don't generate spurious migrations
  2. Creating new tables with uppercase quoted enum type columns generates correct migrations

@ZichaoNickFox
Copy link
Contributor

ZichaoNickFox commented Dec 13, 2025 •
edited
Loading

The requirement maybe useless, please double check. @mpscholten
#2188

@mpscholten
Copy link
Member

mpscholten commented Dec 13, 2025

@copilot I mean code gen for the haskell code

@mpscholten
Add Haskell code generation tests for uppercase custom types
f920996 
Co-authored-by: mpscholten <2072185+mpscholten@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 13, 2025

@copilot I mean code gen for the haskell code

Added Haskell code generation tests in commit f920996. The tests verify that:

  1. Uppercase quoted enum types compile to correct Haskell data types (e.g., "SYMBOL_TYPE" → SymbolType)
  2. Tables with uppercase custom type columns generate correct Haskell record types with the proper field types

@mpscholten
Copy link
Member

mpscholten commented Dec 14, 2025

@copilot tests are failing

@mpscholten
Fix test assertion to use proper comparison method
7c83915 
Co-authored-by: mpscholten <2072185+mpscholten@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 14, 2025

@copilot tests are failing

Fixed in commit 7c83915. Changed test assertion from shouldContain (not available for Text in this context) to extracting the specific data type line and using shouldBe for comparison.

@mpscholten mpscholten marked this pull request as ready for review December 14, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpscholten mpscholten Awaiting requested review from mpscholten

At least 1 approving review is required to merge this pull request.

Assignees

@mpscholten mpscholten

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support capital type definition in .sql?

3 participants

@mpscholten @ZichaoNickFox